lara-pdf-merger icon indicating copy to clipboard operation
lara-pdf-merger copied to clipboard

PHP 8 Compatibility

Open kaptk2 opened this issue 3 years ago • 4 comments

The current version will not run on PHP8. This pull request: https://github.com/tecnickcom/TCPDF/pull/244 seems to fix the issue.

kaptk2 avatar Apr 27 '21 23:04 kaptk2

Hi, this is not applied yet, right? Do I have to rollback to php 7.4 in order to be able to use this package? Thanks!

dhcmega

dhcmega avatar Jun 07 '21 18:06 dhcmega

Well, I just got it working with PHP 8 and Laravel 8 with no troubles whatsoever.

basepack avatar Jun 10 '21 09:06 basepack

Hi It works, the problem starts when there is something regarding fonts:

PHP Deprecated: Required parameter $currentfont follows optional parameter $str in /home /vpssigesedev/sigesedev.huayra.com.ar/vendor/daltcore/lara-pdf-merger/src/LynX39/LaraPdfMerger/tcpdf/include/tcpdf_fonts.php on line 2072

dhcmega avatar Jun 10 '21 12:06 dhcmega

I only use it to merge PDF files, nothing special really. Maybe that is why it worked at once fore me.

Edit: currently also getting this error! For some reason not always when merging pdfs.

Edit2: fixed in TCPDF 6.4.1: https://github.com/tecnickcom/TCPDF/issues/222

basepack avatar Jun 10 '21 14:06 basepack