hamilton icon indicating copy to clipboard operation
hamilton copied to clipboard

[good first issue - beginner][examples] regenerate all visualizations

Open skrawcz opened this issue 2 years ago • 8 comments

What

With https://github.com/DAGWorks-Inc/hamilton/pull/169 our visualizations will be more discerning.

Task

We now have stale images. Task is to regenerate all the ones we have in documentation and in the examples folders.

Examples

For each directory please:

  1. Identify what images need to be regenerated. E.g. if the image has nodes with "UD:" in it instead of "Input:". Please mark it and note which image it is if there's several.
  2. Then regenerate the image(s) for those examples, using visualize_execution using the given code. You will need to install dependencies to make the example(s) work.

Examples

  • [ ] LLM_Workflows
  • [ ] airflow
  • [ ] async
  • [ ] caching_nodes
  • [ ] dask
  • [ ] data_loaders
  • [x] data_quality
  • [ ] dbt
  • [ ] feast
  • [ ] feature_engineering
  • [ ] hello_world
  • [ ] lineage
  • [ ] materialization
  • [ ] model_examples
  • [ ] numpy/air-quality-analysis
  • [ ] pandas/materialization
  • [ ] parallelism
  • [ ] polars
  • [ ] prefect
  • [ ] ray
  • [ ] reusing_functions
  • [x] scikit-learn
  • [ ] spark

skrawcz avatar May 18 '23 06:05 skrawcz

Hey @skrawcz can I work on this issue? Are you referring to the visulatization inside example/ folder?

bovem avatar May 27 '23 07:05 bovem

Sure @bovem. To confirm, yes I am talking about regenerating all the images that are in the examples folders.

Most of them were generated with the visualize_execution() function, but some weren't -- so if you get stuck let me know.

skrawcz avatar May 27 '23 20:05 skrawcz

Hey @skrawcz, can I work on this issue ?

subhamc1 avatar Oct 02 '23 07:10 subhamc1

@subhamc1 sure -- does the description make sense?

skrawcz avatar Oct 02 '23 14:10 skrawcz

@skrawcz yes, it does.

subhamc1 avatar Oct 02 '23 15:10 subhamc1

@skrawcz yes, it does.

Assigned!

skrawcz avatar Oct 02 '23 16:10 skrawcz

@subhamc1 let me know what should be checked off please :)

skrawcz avatar Oct 24 '23 16:10 skrawcz

I did data_quality and scikit-learn.

subhamc1 avatar Nov 02 '23 05:11 subhamc1