review third party code in examples/ibis/jaffle_shop

Open pjfanning opened this issue 5 months ago • 2 comments

https://github.com/apache/hamilton/blob/e0333384a3d10c72d78540c521f836f06688a696/examples/ibis/jaffle_shop/README.md

If we have any code in Hamilton repo copied from third party sources, we need to review the licenses and see what we need to add to our license.

@skrawcz could you or another PPMC member review the license implications here? The first aim is to find out what if any code is based on 3rd party code including sample code.

Jul 27 '25 14:07 pjfanning

@pjfanning yeah I reviewed this, this is a reimplementation. So original code contributed. Not copied.

For reference, the example referenced is Apache 2 licensed.

Sep 06 '25 20:09 skrawcz

It is not just about the license - it affects the LICENSE file that Hamilton ships in its source releases. All 3rd party source code needs to be mentioned in including what license type applies. For non Apache licenses on 3rd party source, we need to embed the full license text.

Sep 06 '25 20:09 pjfanning