dao-contracts
dao-contracts copied to clipboard
Add active threshold functionality to CW4 voting module, closes #781
Changelog
- Added new custom error message to error.rs,
InvalidThreshold
- Added the
query_is_active
function and correspondingQuery::IsActive
- Added the
execute_update_active_threshold
function and correspondingExecuteMsg::UpdateActiveThreshold
- Added the new optional
Config
and updated theinstantiate
function to make use of it.
Author
GhostMac
Needs a few things:
- Fix the build
- Add tests for
active_threshold
and being able to update it - Make sure CI passes
- Clean up
Needs a few things:
- Fix the build
- Add tests for
active_threshold
and being able to update it- Make sure CI passes
- Clean up
I have updated the contract with everything you pointed out. Build passes. Moving on to the tests.
Needs a few things:
- Fix the build
- Add tests for
active_threshold
and being able to update it- Make sure CI passes
- Clean up
I have updated the contract with everything you pointed out. Build passes. Moving on to the tests.
Close, but see above comments.
- Get rid of
CONFIG
, it's duplicate state for no reason - Make sure to save
ACTIVE_THRESHOLD
on instantiation and validate that it's NOTACTIVE_THRESHOLD::Percent
- Get rid of
ACTIVE_THRESHOLD::Percent
in theIsActive
query, it does nothing right now and we should not allow it - Fix linting errors and tests, CI should pass