dao-contracts icon indicating copy to clipboard operation
dao-contracts copied to clipboard

upgrade to cosmwasm 1.1

Open blue-note opened this issue 2 years ago • 2 comments

upgrades to cosmwasm 1.1 as per this doc.

things that need careful eyes:

  • the query macro modifications (packages/cwd-macros/src/lib.rs)
  • the schema and typescript codegen modifications
  • the QueryMsg return attributes

blue-note avatar Oct 14 '22 21:10 blue-note

Codecov Report

Base: 91.68% // Head: 91.25% // Decreases project coverage by -0.42% :warning:

Coverage data is based on head (8d48223) compared to base (355f8c8). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #511      +/-   ##
==========================================
- Coverage   91.68%   91.25%   -0.43%     
==========================================
  Files          38       38              
  Lines        3668     3695      +27     
==========================================
+ Hits         3363     3372       +9     
- Misses        305      323      +18     
Impacted Files Coverage Δ
contracts/external/cw-token-swap/src/state.rs 100.00% <ø> (ø)
...e-propose/cwd-pre-propose-multiple/src/contract.rs 100.00% <ø> (ø)
...pre-propose/cwd-pre-propose-single/src/contract.rs 100.00% <ø> (ø)
...cts/proposal/cwd-proposal-multiple/src/contract.rs 91.85% <ø> (ø)
...cts/proposal/cwd-proposal-multiple/src/proposal.rs 90.24% <ø> (ø)
...racts/proposal/cwd-proposal-single/src/contract.rs 99.29% <ø> (ø)
...racts/proposal/cwd-proposal-single/src/proposal.rs 95.45% <ø> (ø)
...racts/proposal/cwd-proposal-single/src/v1_state.rs 96.29% <ø> (+1.55%) :arrow_up:
contracts/staking/cw20-stake/src/contract.rs 87.24% <ø> (ø)
contracts/staking/cw20-stake/src/hooks.rs 100.00% <ø> (ø)
... and 41 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Oct 14 '22 21:10 codecov-commenter

Cosm-Orc Gas Usage

Contract Op Name Gas Used Old Gas Used Gas Diff File
cwd_core Store__Store 45996040 45404020 +1.3039% ci/integration-tests/src/helpers/chain.rs:98
cw20_stake Store__Store 29285060 28858700 +1.4774% ci/integration-tests/src/helpers/chain.rs:98
cw_token_swap Store__Store 20276940 19327750 +4.9110% ci/integration-tests/src/helpers/chain.rs:98
cwd_pre_propose_single Store__Store 33151120 32975010 +0.5341% ci/integration-tests/src/helpers/chain.rs:98
cwd_proposal_single Store__Store 53896020 52785680 +2.1035% ci/integration-tests/src/helpers/chain.rs:98
cwd_voting_cw20_staked Store__Store 29905635 29338585 +1.9328% ci/integration-tests/src/helpers/chain.rs:98
cwd_voting_cw4 Store__Store 22062790 21746540 +1.4543% ci/integration-tests/src/helpers/chain.rs:98
cwd_voting_cw721_staked Store__Store 31326440 31069590 +0.8267% ci/integration-tests/src/helpers/chain.rs:98
cwd_voting_native_staked Store__Store 24601370 24412610 +0.7732% ci/integration-tests/src/helpers/chain.rs:98
cwd_voting_staking_denom_staked Store__Store 17908970 17433000 +2.7303% ci/integration-tests/src/helpers/chain.rs:98
stake_cw20_external_rewards Store__Store 26120250 25375000 +2.9369% ci/integration-tests/src/helpers/chain.rs:98
stake_cw20_reward_distributor Store__Store 19956840 19378680 +2.9835% ci/integration-tests/src/helpers/chain.rs:98
Raw Report for 32c410f0ad8103eb6d1c39200f0f5eddf6baf8a0
Contract Op Name Gas Used Gas Wanted File
cwd_core Execute__exc_items_rm 192600 264389 ci/integration-tests/src/tests/cw_core_test.rs:174
cwd_core Execute__exc_items_set 194268 266891 ci/integration-tests/src/tests/cw_core_test.rs:139
cwd_core Instantiate__exc_items_create_dao 1201304 1777343 ci/integration-tests/src/helpers/helper.rs:98
cwd_core Instantiate__exc_stake_create_dao 1200230 1775733 ci/integration-tests/src/helpers/helper.rs:98
cwd_core Instantiate__inst_admin_create_dao 1201304 1777343 ci/integration-tests/src/helpers/helper.rs:98
cwd_core Execute__exc_admin_msgs_pause_dao 194394 267078 ci/integration-tests/src/tests/cw_core_test.rs:79
cwd_core Instantiate__exc_admin_msgs_create_dao 1200254 1775769 ci/integration-tests/src/helpers/helper.rs:98
cwd_core Instantiate__exc_admin_msgs_create_dao_with_admin 1201304 1777343 ci/integration-tests/src/helpers/helper.rs:98
cwd_core Store__Store 45996040 68969420 ci/integration-tests/src/helpers/chain.rs:98
cwd_core Instantiate__inst_dao_no_admin 1200254 1775769 ci/integration-tests/src/helpers/helper.rs:98
cw20_base Execute__exc_stake_stake_tokens 234578 319223 ci/integration-tests/src/tests/cw20_stake_test.rs:76
cw20_base Store__Store 34543940 51791270 ci/integration-tests/src/helpers/chain.rs:98
cw20_stake Store__Store 29285060 43902950 ci/integration-tests/src/helpers/chain.rs:98
cw4_group Store__Store 23034310 34526825 ci/integration-tests/src/helpers/chain.rs:98
cw_admin_factory Store__Store 16332340 24473870 ci/integration-tests/src/helpers/chain.rs:98
cw_token_swap Store__Store 20276940 30390770 ci/integration-tests/src/helpers/chain.rs:98
cwd_pre_propose_multiple Store__Store 33703650 50530835 ci/integration-tests/src/helpers/chain.rs:98
cwd_pre_propose_single Store__Store 33151120 49702040 ci/integration-tests/src/helpers/chain.rs:98
cwd_proposal_multiple Store__Store 52041530 78037655 ci/integration-tests/src/helpers/chain.rs:98
cwd_proposal_single Store__Store 53896020 80819390 ci/integration-tests/src/helpers/chain.rs:98
cwd_voting_cw20_staked Store__Store 29905635 44834141 ci/integration-tests/src/helpers/chain.rs:98
cwd_voting_cw4 Store__Store 22062790 33069545 ci/integration-tests/src/helpers/chain.rs:98
cwd_voting_cw721_staked Store__Store 31326440 46965020 ci/integration-tests/src/helpers/chain.rs:98
cwd_voting_native_staked Store__Store 24601370 36877415 ci/integration-tests/src/helpers/chain.rs:98
cwd_voting_staking_denom_staked Store__Store 17908970 26838815 ci/integration-tests/src/helpers/chain.rs:98
stake_cw20_external_rewards Store__Store 26120250 39155735 ci/integration-tests/src/helpers/chain.rs:98
stake_cw20_reward_distributor Store__Store 19956840 29910620 ci/integration-tests/src/helpers/chain.rs:98

github-actions[bot] avatar Oct 14 '22 21:10 github-actions[bot]

two things from working off a fork that i think we can improve here:

  1. the rfc for this uses dep = { workspace = true } everywhere (does not use dep.workspace = true). i personally prefer that format as understanding it doesn't require understanding new YAML syntax.
  2. it would be really nice to add local dependencies to the workspace. the rfc talks about this here. doing this will make moving files around much easier and makes sure our versioning is consistent everywhere.

@blue-note do you have time to take a look at these? i can as well but it'll bump into other stuff.

0xekez avatar Nov 01 '22 01:11 0xekez

two things from working off a fork that i think we can improve here:

  1. the rfc for this uses dep = { workspace = true } everywhere (does not use dep.workspace = true). i personally prefer that format as understanding it doesn't require understanding new YAML syntax.
  2. it would be really nice to add local dependencies to the workspace. the rfc talks about this here. doing this will make moving files around much easier and makes sure our versioning is consistent everywhere.

@blue-note do you have time to take a look at these? i can as well but it'll bump into other stuff.

sure, I can take a look tomorrow!

blue-note avatar Nov 01 '22 01:11 blue-note