dao-contracts icon indicating copy to clipboard operation
dao-contracts copied to clipboard

Add proposal hooks macro

Open Callum-A opened this issue 2 years ago • 3 comments

Closes #459

  • Adds a macro to derive proposal hooks
  • Adds a macro to derive vote hooks

Callum-A avatar Oct 09 '22 17:10 Callum-A

Codecov Report

Base: 93.95% // Head: 93.27% // Decreases project coverage by -0.67% :warning:

Coverage data is based on head (f9ac752) compared to base (48d9629). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #498      +/-   ##
==========================================
- Coverage   93.95%   93.27%   -0.68%     
==========================================
  Files          37       39       +2     
  Lines        3589     3615      +26     
==========================================
  Hits         3372     3372              
- Misses        217      243      +26     
Impacted Files Coverage Δ
packages/cwd-proposal-hooks-macros/src/lib.rs 0.00% <0.00%> (ø)
packages/cwd-vote-hooks-macros/src/lib.rs 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Oct 09 '22 17:10 codecov-commenter

Cosm-Orc Gas Usage

No gas diff larger than 0.5%

Raw Report for f9ac75208d54c29f9aee1771ab6e22774ac9a904
Contract Op Name Gas Used Gas Wanted File
cwd_core Instantiate__inst_admin_create_dao 1201304 1777343 ci/integration-tests/src/helpers/helper.rs:98
cwd_core Store__Store 45996040 68969420 ci/integration-tests/src/helpers/chain.rs:98
cwd_core Execute__exc_admin_msgs_pause_dao 194394 267078 ci/integration-tests/src/tests/cw_core_test.rs:79
cwd_core Instantiate__exc_admin_msgs_create_dao 1200254 1775769 ci/integration-tests/src/helpers/helper.rs:98
cwd_core Instantiate__exc_admin_msgs_create_dao_with_admin 1201304 1777343 ci/integration-tests/src/helpers/helper.rs:98
cwd_core Instantiate__inst_dao_no_admin 1200254 1775769 ci/integration-tests/src/helpers/helper.rs:98
cwd_core Execute__exc_items_rm 192600 264389 ci/integration-tests/src/tests/cw_core_test.rs:174
cwd_core Execute__exc_items_set 194268 266891 ci/integration-tests/src/tests/cw_core_test.rs:139
cwd_core Instantiate__exc_items_create_dao 1201304 1777343 ci/integration-tests/src/helpers/helper.rs:98
cwd_core Instantiate__exc_stake_create_dao 1200230 1775733 ci/integration-tests/src/helpers/helper.rs:98
cw20_base Store__Store 34543940 51791270 ci/integration-tests/src/helpers/chain.rs:98
cw20_base Execute__exc_stake_stake_tokens 234578 319223 ci/integration-tests/src/tests/cw20_stake_test.rs:76
cw20_stake Store__Store 29285060 43902950 ci/integration-tests/src/helpers/chain.rs:98
cw4_group Store__Store 23034310 34526825 ci/integration-tests/src/helpers/chain.rs:98
cw_admin_factory Store__Store 16332340 24473870 ci/integration-tests/src/helpers/chain.rs:98
cw_token_swap Store__Store 20276940 30390770 ci/integration-tests/src/helpers/chain.rs:98
cwd_pre_propose_multiple Store__Store 33703650 50530835 ci/integration-tests/src/helpers/chain.rs:98
cwd_pre_propose_single Store__Store 33151120 49702040 ci/integration-tests/src/helpers/chain.rs:98
cwd_proposal_multiple Store__Store 52041530 78037655 ci/integration-tests/src/helpers/chain.rs:98
cwd_proposal_single Store__Store 53896020 80819390 ci/integration-tests/src/helpers/chain.rs:98
cwd_voting_cw20_staked Store__Store 29905635 44834141 ci/integration-tests/src/helpers/chain.rs:98
cwd_voting_cw4 Store__Store 22062790 33069545 ci/integration-tests/src/helpers/chain.rs:98
cwd_voting_cw721_staked Store__Store 31326440 46965020 ci/integration-tests/src/helpers/chain.rs:98
cwd_voting_native_staked Store__Store 24601370 36877415 ci/integration-tests/src/helpers/chain.rs:98
cwd_voting_staking_denom_staked Store__Store 17908970 26838815 ci/integration-tests/src/helpers/chain.rs:98
stake_cw20_external_rewards Store__Store 26120250 39155735 ci/integration-tests/src/helpers/chain.rs:98
stake_cw20_reward_distributor Store__Store 19956840 29910620 ci/integration-tests/src/helpers/chain.rs:98

github-actions[bot] avatar Oct 09 '22 17:10 github-actions[bot]

looks great :) just needs a rebase on the new naming stuff. sorry to rug with that

0xekez avatar Oct 18 '22 21:10 0xekez

gonna get rugged by this too if we don't rebase and merge this soon: https://github.com/DA0-DA0/dao-contracts/pull/516

0xekez avatar Nov 01 '22 23:11 0xekez

@0xekez, think this one is good to go now?

JakeHartnell avatar Nov 20 '22 21:11 JakeHartnell

Going to close this as macros have changed a bit, and the hooks are actually a bit different from how they are in the macros. I will be picking up this work today as I tackle #509.

JakeHartnell avatar Nov 21 '22 22:11 JakeHartnell