dao-contracts icon indicating copy to clipboard operation
dao-contracts copied to clipboard

Absolute count threshold for multi-proposals

Open 0xarbi opened this issue 1 year ago • 2 comments

Related issue https://github.com/DA0-DA0/dao-contracts/issues/368

Approach

  • Pull the { quorum: PercentageThreshold } constraint into a MultipleProposalThreshold enum that also allows configuring for a { threshold: Uint128 } constraint
  • Update logic in contract.rs to accomodate for these changes when verifying the status of a proposal
  • Amend many of the tests to accomodate for this new logic

0xarbi avatar Oct 06 '22 23:10 0xarbi

wow so fast! nice!

blue-note avatar Oct 07 '22 18:10 blue-note

thanks for this change! looks good at a skim.

we're currently getting really close to releasing v2 of the contracts. thinking we're going to wait on landing this change until that is live. there will be some rebase conflicts here as we're doing some file renaming, but we can return to this / get those fixed once v2 is out!

0xekez avatar Oct 11 '22 00:10 0xekez