dao-contracts icon indicating copy to clipboard operation
dao-contracts copied to clipboard

Query by proposal status and voting status. Easy implementation

Open Buckram123 opened this issue 2 years ago • 1 comments

It's simple implementation of #237 query. What do you think @ezekiiel? Unsure if we should show created proposals too? How do i test gas usage? Via cosmwasm-vm?

I can try to implement https://github.com/DA0-DA0/dao-contracts/issues/237#issuecomment-1187977788 But I think this way we increase gas usage on votes?

TODO(If we ok with this):

  • [ ] test gas
  • [x] implement same for cw-proposal-multiple module
  • [x] test pagination

Closes #237

Buckram123 avatar Jul 20 '22 16:07 Buckram123

@Buckram123 how are things going? If you're tight on time or otherwise occupied (which would be extremely valid given your situation) I'm happy to pick up the last few things here. :)

0xekez avatar Aug 15 '22 20:08 0xekez

@Buckram123 after much iteration in this area, i think we've decided to go in the direction of using indexers for these kinds of queries. that gives us wins in contract simplicity and in performance. this query is superseded by the indexer that we built here.

i really appreciate your work getting this ready. not landing this is not in any way a reflection of the code here or how talented you are. :) this work got us started iterating on this question, and the end result is that indexers are probably the way. thank you again for the really nice PR!

0xekez avatar Oct 07 '22 20:10 0xekez

@ezekiiel thank you for giving me such a great opportunity to get the best reviews in my life. (: I like the direction you decided to pick, would love to play around with the indexer you guys are creating!

Buckram123 avatar Oct 07 '22 20:10 Buckram123