Cytnx icon indicating copy to clipboard operation
Cytnx copied to clipboard

Default values with and without using CMakePresents.json

Open pcchen opened this issue 3 months ago • 2 comments

It seems that the default values with and without using CMakePresents.json are not consistent.

If I use cmake -S . -B build the default value for USE_HPTT is OFF. If I use cmake -S . -B build --preset openblas-cpu the default value for USE_HPTT is ON.

Is this on-purpose or should we make them consistent?

pcchen avatar Sep 07 '25 05:09 pcchen

We should make USE_HPTT=on by default

yingjerkao avatar Sep 07 '25 06:09 yingjerkao

When we refactored CMakeLists.txt, we preserved the original default configuration in CMakeLists.txt, so the default configuration in CMakeLists.txt and in CMakePresets.json are different. I agree; it would be best to keep them consistent.

IvanaGyro avatar Sep 07 '25 07:09 IvanaGyro