ProcessX icon indicating copy to clipboard operation
ProcessX copied to clipboard

Add variant of GetDualAsyncEnumerable that returns binary

Open Funkest opened this issue 9 months ago • 3 comments

  • This PR introduces a new method ~~StartReadBinaryWithErrOutAsync~~ that addresses a limitation in the current implementation.

  • When executing apps that write diagnostic messages to stderr while also producing binary output on stdout (e.g. ffmpeg), the current implementation fails to capture the binary output correctly. Even when the process exits with a successful code (0), the binary output is lost.

  • The implementation has been tested with the example in sandbox/BinaryWithErrorOutput which demonstrates the functionality with a real-world scenario.

Funkest avatar Mar 22 '25 14:03 Funkest

  • The implementation was brought closer to GetDualAsyncEnumerable. The previous implementation was fatally bad in practice because it couldn't retrieve stderr until stdout was complete, so it was changed.
  • Renamed the method to GetDualAsyncEnumerableBinary from StartReadBinaryWithErrOutAsync after its implemention update.

*Edited PR title to resolve mismatching with codes.

Funkest avatar Mar 23 '25 05:03 Funkest

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Sep 20 '25 00:09 github-actions[bot]

keep

Funkest avatar Sep 20 '25 01:09 Funkest