ConsoleAppFramework icon indicating copy to clipboard operation
ConsoleAppFramework copied to clipboard

Fixes #124 - Created alias variable by allowing multiple command attributes

Open BlackPhlox opened this issue 1 year ago • 2 comments

First draft for how to fix #124.

Created alias variable by allowing multiple command attributes, generation changes and test that passes.

BlackPhlox avatar Jun 16 '24 00:06 BlackPhlox

CommandAliasWithRoot currently fails as it generates a switch case for which there are no switches generated at that location due to being root.

BlackPhlox avatar Jun 16 '24 09:06 BlackPhlox

Thank you, I ran the code and checked it.

The choice to allow setting multiple Commands is OK. Since I think only some users will use it, it's good that it doesn't change for normal use cases.

Regarding the code: Having the emit for aliases in EmitRunBody feels a bit off, I feel there might be a more appropriate place for it. Also, the output code unnecessarily indented the case statements. string[] Aliases probably won't be Incremental, so an Incremental test is needed (see IncrementalGeneratorTest).

neuecc avatar Jun 18 '24 10:06 neuecc

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Dec 16 '24 00:12 github-actions[bot]