ConsoleAppFramework icon indicating copy to clipboard operation
ConsoleAppFramework copied to clipboard

Added support for class inheritence for command classes

Open riddlemd opened this issue 2 years ago • 3 comments

Removed BindingFlags.DeclaredOnly from generic add methods and changed DeclaringType to ReflectedType in ConsoleAppEngine. This allows the use of command classes that inherit their commands form a parent class.

(last one I swear... pretty sure I tracked down all the bugs)

This update no longer hides the dispose methods, I recommend implicitly implementing the interface so they don't show up. It has a list of not allowed to inherit methods, but is implemented in a way that allows those methods to still show up in the console list if they're explicitly defined in the class for whatever reason (we don't check args, so you could have an Equals method for example that does something completely different than normal.)

riddlemd avatar Jul 07 '23 03:07 riddlemd

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Jan 04 '24 00:01 github-actions[bot]

Gonna die on the vine hu?

riddlemd avatar Jan 10 '24 16:01 riddlemd

sorry for delayed response, i'll check soon.

neuecc avatar Jan 12 '24 05:01 neuecc

sorry, we've moved to v5.

neuecc avatar Jun 02 '24 18:06 neuecc

All good, does v5 support inheritance? If not I can start looking into adding it to that.

riddlemd avatar Jun 02 '24 18:06 riddlemd