Cyril Vallez
Cyril Vallez
IMO the logic in `leave_Class` in `ModularConverterTransformer` is much simpler now, let me know what you think I may be biased 😅🤗
> Also, while removing the init from the modular implementation as suggested, the generated modeling code does not have self.config_class = ArceeConfig from the previous version. Is that redundant as...
Hey! Your first way of doing is correct, but indeed, this is a small bug due to an import in `superglue`: you can solve it in the PR by switching...
cc @vasqu here as well for FA2, seems like we have a regresion if everything was 1:1 before! Not the first issue about that recently I think, if you can...
cc @vasqu here, I don't remember, is this expected to fail or not? Do we only accept list inputs?
Hey @HichTala! Are you sure you are still facing the original issue in latest `main`? Loading has changed, and we do not use `model.load_state_dict` anymore!
I see... Then this config switch should be hardcoded in all model config when this can happen, not in the general loading code! Do you want to make the change?
It probably comes from `output_hidden_states=True`, I believe they don't get cleaned up correctly or something cause some other threads keep a ref probably. Could you try without it? Also, would...
After more offline discussion with @molbap, we both agreed that this PR is way too dangerous in general. We cannot accept it in the current state. What we believe keeps...
Just answered you for the config thing! Let me know when you made the change, and I'll review again!