honeycomb_plugins icon indicating copy to clipboard operation
honeycomb_plugins copied to clipboard

Make syslog facility code configurable

Open claudijd opened this issue 7 years ago • 4 comments

An untested attempt at fixing syslog facility parameter

Closes #103

claudijd avatar Aug 30 '18 20:08 claudijd

Codecov Report

Merging #104 into master will decrease coverage by 0.03%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
- Coverage   67.98%   67.94%   -0.04%     
==========================================
  Files          47       47              
  Lines        1899     1900       +1     
==========================================
  Hits         1291     1291              
- Misses        608      609       +1
Impacted Files Coverage Δ
integrations/syslog/integration.py 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f251328...31125f1. Read the comment docs.

codecov[bot] avatar Aug 30 '18 21:08 codecov[bot]

Looks good but please test and report back as we dont have automated testing for integrations yet

omercnet avatar Aug 31 '18 06:08 omercnet

@claudijd did you manage to test this code? It will be great to approve this PR, but we want to make sure everything works before we push things to master.

dekelb avatar Nov 06 '18 11:11 dekelb

@dekelb I wasn't able to test, and I no longer needing this patch upstream. That said, I think there is value leaving it open as a consideration for improvement, should someone have the ability to confirm or ammend it's viability.

claudijd avatar Nov 06 '18 13:11 claudijd