Simon Ninon

Spent some time benchmarking a bit rapidjson by doing 1000 GetNodeInfo. Performance is same compared to our current json library. However, as of now, rapidjson uses more memory than our...

Just checked exceptions. We mostly have exceptions for: * Invalid model states * Network failures * Invalid parameters Our exception usage is pretty much limited to corner cases and not...

I developed multiple others open source project and was only providing CMake at the very beginning. However I was asked multiple times about how to use CMake or where could...

I 100% with you 👍 Our main focus is definitely the CMake as it makes the build chain portable and flexible. We will always prioritize the CMake build and highly...

Turns out cpr dependency does not provide any MSVC solution in their repository, as well as its sub-dependency mongoose. This makes it impossible to provide an MSVC solution without creating...

Can you briefly describe what is the current bug and how this change fix it? Will help for review and for record, thanks!

For this one, can you confirm the assumptions made when talking about it privately / safe to merge?

For this one, was a bit confused by the wording, but after investigation, seems that what we actually need to do is to support a new parameter `depth` for isPromotable....

Thanks, @chrisdukakis (sorry for the late reply!). Sounds reasonable, we will need to state it in the CHANGELOG once we release. The main advantage of sendTransfer() is that it made...

# Performance degradation report ../../build/bin/responses_were_addresses_spent_from_test: was 0.0, now 0.002673413 (+Inf%) ../../build/bin/core_get_trytes_test: was 0.0, now 0.074619049 (+Inf%) ../../build/bin/core_get_transactions_to_approve_test: was 0.0, now 0.052522042 (+Inf%) ../../build/bin/core_get_balances_test: was 0.0, now 0.030051051 (+Inf%) ../../build/bin/extended_send_transfer_test: was...