raven icon indicating copy to clipboard operation
raven copied to clipboard

Validate if symlink edgecase still exist when indexing

Open oreenlivnicode opened this issue 2 years ago • 1 comments

if isinstance(obj, str):
                # TODO: This is a symlink. We should handle it.
                # Only examples at the moment are for https://github.com/edgedb/edgedb-pkg
                # E.g. https://github.com/edgedb/edgedb-pkg/blob/master/integration/linux/build/centos-8/action.yml
                logger.debug(f"[-] Symlink detected: {content}. Skipping...")
                return

This code block appears twice in indexer.py. We should validate if this bug still exists, and if so, fix it.

oreenlivnicode avatar Sep 27 '23 14:09 oreenlivnicode

Even though the checks are in the indexer, the fix should be in the downloader (so I labeled accordingly). I believe the bug still exists, as we did nothing in the downloader to handle symlinks.

alex-ilgayev avatar Nov 05 '23 12:11 alex-ilgayev