transparency-exchange-api icon indicating copy to clipboard operation
transparency-exchange-api copied to clipboard
Published 2 months ago • verified publisher icon CycloneDX

Cherrypick out linter

Open vpetersson opened this issue 8 months ago • 5 comments

Cherry pick out Markdown linter without actually running it.

vpetersson avatar Apr 16 '25 14:04 vpetersson

@vpetersson - any reason you have chosen not to use an existing GitHub Action for this?

  • https://github.com/DavidAnson/markdownlint-cli2-action
  • https://github.com/super-linter/super-linter

madpah avatar Apr 17 '25 11:04 madpah

@madpah I've found Super Linter to be super slow (and bloated) in the past. I just copied this from other pipelines where I've added this setup. We could definitely add an upstream Action, but it was just a few lines so i figured it was easier to implement.

However, if you feel strongly that we should use an existing action, I can change it.

vpetersson avatar Apr 17 '25 13:04 vpetersson

No strong opinion - just having the chat 😉

madpah avatar Apr 17 '25 13:04 madpah

All good, mate! Yeah I usually try to use (well maintained) Action modules too, but haven't found a good one for this.

Also, note that the tests are failing because I didn't run it. @oej asked me to not apply the linting in this PR.

vpetersson avatar Apr 17 '25 13:04 vpetersson

Hmm. This fails because of the workflow with the linter... Isn't that weird or should it be that way? Anything we have to do before merging?

oej avatar Apr 30 '25 06:04 oej