specification icon indicating copy to clipboard operation
specification copied to clipboard

Adapt test samples to ensure consistency between the different formats

Open andreas-hilti opened this issue 1 year ago • 1 comments

Closes: https://github.com/CycloneDX/specification/issues/513

andreas-hilti avatar Aug 31 '24 22:08 andreas-hilti

At the moment, with all fixes to the library, only 2 of the consistency checks in https://github.com/CycloneDX/cyclonedx-dotnet-library/pull/331 fail:

  • valid-bom-1.6: significant changes in the content between xml and JSON; I wasn't sure how to best adapt it
  • valid-license-expression-1.6: license expression can't have a bom-ref currently in protobuf (https://github.com/CycloneDX/specification/issues/515)

andreas-hilti avatar Aug 31 '24 23:08 andreas-hilti

the blocking issues were solved. feel free to rebase/merge, your work is appreciated very much.

jkowalleck avatar Nov 07 '24 15:11 jkowalleck

@jkowalleck Like this all the consistency tests would be passing. Do you know why the Java test are failing? (I didn't touch valid-standard-1.6.xml nor valid-component-data-1.6.xml; but I see that it fails also on master.)

andreas-hilti avatar Nov 07 '24 21:11 andreas-hilti

Do you know why the Java test are failing?

we've updated the XML schema, and it is not reflected by the java tests due to https://github.com/CycloneDX/specification/issues/256

jkowalleck avatar Nov 08 '24 00:11 jkowalleck

received no negative feedback from community. so we assume all are cool with the proposed changes to the test data.

thank you for your contribution, @andreas-hilti !

jkowalleck avatar Nov 18 '24 07:11 jkowalleck