specification icon indicating copy to clipboard operation
specification copied to clipboard

Published 20 hours ago • verified publisher icon CycloneDX

Protobuf `metadata.tools` not updated in v1.5

Open coderpatros opened this issue 2 years ago • 4 comments

coderpatros avatar Aug 02 '23 05:08 coderpatros

i will take this over

jkowalleck avatar Feb 08 '24 03:02 jkowalleck

will have this issue fixed, as soon as https://github.com/CycloneDX/specification/pull/385 is done

jkowalleck avatar Feb 28 '24 13:02 jkowalleck

v1.4: https://github.com/CycloneDX/specification/blob/8af880d5f2ba0a107de88a920a76cedd5ba75083/schema/bom-1.4.proto#L282

v1.5: https://github.com/CycloneDX/specification/blob/8af880d5f2ba0a107de88a920a76cedd5ba75083/schema/bom-1.5.proto#L424

Once, tools was a repeated list of Tool ... Now is just one element at max? wtf ... this was an odd decision ... Because now I can express one tool at max. not all of them ... well, this was a breaking change .... again ...

But at least the Tool got a list of compoentns and services to represent other "tools" https://github.com/CycloneDX/specification/blob/c320fc0f0b46873864927d9d5684eea7ba439728/schema/bom-1.5.proto#L599-L602

To me this issue seams to be solved, even though the solution was just odd.

jkowalleck avatar Mar 18 '24 12:03 jkowalleck

@coderpatros could you review my conclusion, and decide whether the issue is solved?

jkowalleck avatar Mar 18 '24 12:03 jkowalleck