cyclonedx-python-lib icon indicating copy to clipboard operation
cyclonedx-python-lib copied to clipboard

feat: add `cyclonedx.model.dependency.Dependency.provides`

Open uzairchhapra opened this issue 1 year ago • 7 comments

Fixes #691

uzairchhapra avatar Nov 05 '24 19:11 uzairchhapra

@jkowalleck PR is ready for review. I am not too sure about the test cases so any guidance here would help. Thanks!

uzairchhapra avatar Nov 05 '24 21:11 uzairchhapra

thank you for your contribution, @uzairchhapra .

the implementation looks promising.

Regarding tests, we tend to go with an integration-test snapshot-solution, over detailed unit tests. Please add new fixtures to https://github.com/CycloneDX/cyclonedx-python-lib/blob/main/tests/_data/models.py. your new function must start with get_bom_. After adding new test data, please recreate the snapshots as described here: https://github.com/CycloneDX/cyclonedx-python-lib/blob/main/tests/_data/snapshots/README.md

jkowalleck avatar Nov 10 '24 15:11 jkowalleck

@uzairchhapra , could you also see to integrate some plausibility-checks into model.bom.validate()

PS: you already did that, found it. that is fantastic.

jkowalleck avatar Nov 11 '24 15:11 jkowalleck

@uzairchhapra, I just wanted to ask how things are going. Do you need any help with one of the open discussions/points?

jkowalleck avatar Jan 15 '25 12:01 jkowalleck

@uzairchhapra, I just wanted to ask how things are going. Do you need any help with one of the open discussions/points?

Apologies for the delayed response. I will get to this this weekend. If I remember correctly, I was stuck in making the test function work get_bom_v1_6_with_provides. I see my PR has some conflicts now, so will try to address that too.

uzairchhapra avatar Jan 27 '25 17:01 uzairchhapra

Hi everyone, Thanks a lot for your amazing work!! Just wanted to check in—I'm currently waiting on this fix to be released, as it's blocking some of our work. Really appreciate all the efforts from the maintainers and contributors here. Is there any estimated timeline for when this might be included in a release? Thanks in advance!

aespogom avatar Mar 27 '25 13:03 aespogom

@aespogom I'm not affiliated, but it looks as though the author has abandoned this PR. If it's blocking you, would you consider picking it up?

robertlagrant avatar Apr 03 '25 18:04 robertlagrant