cyclonedx-maven-plugin icon indicating copy to clipboard operation
cyclonedx-maven-plugin copied to clipboard

cyclonedx-maven-plugin is not marked with @threadSafe run in Multi threaded maven build

Open rvsoni opened this issue 4 years ago • 2 comments

From maven build log,

mvn -T 4 clean install

[WARNING] The following plugins are not marked @threadSafe in A-Project: [WARNING] org.cyclonedx:cyclonedx-maven-plugin:2.1.0

rvsoni avatar Dec 17 '20 07:12 rvsoni

+1

Aljodomo avatar Feb 21 '22 14:02 Aljodomo

I think some investigation needs to be done to determine if the plugin is thread safe or not. I think it is, but if anyone wants to verify that, that would be great.

stevespringett avatar Feb 21 '22 23:02 stevespringett

+1

penzhang avatar Jan 14 '23 18:01 penzhang

I'll have a second look at the code to check if I see anything that would prevent the goal to be thread safe...

hboutemy avatar Jan 24 '23 07:01 hboutemy

Implemented in #264. Having to manual close as a bug in GitHub itself prevented the PR from closing and this ticket to be updated as well. Thanks again @hboutemy for confirming the code was thread safe and for putting in the proper Maven flags to indicate such.

stevespringett avatar Jan 24 '23 15:01 stevespringett

FYI @stevespringett : https://issues.apache.org/jira/browse/HBASE-27634 . We're on the latest 2.7.3.

ndimiduk avatar Feb 11 '23 11:02 ndimiduk

@ndimiduk FYI 2.7.4 is the latest.

stevespringett avatar Feb 11 '23 19:02 stevespringett

@stevespringett I don't think this is working properly even on 2.7.4. To @ndimiduk 's point, this is from my HBase build.

[WARNING] *****************************************************************
[WARNING] * Your build is requesting parallel execution, but project      *
[WARNING] * contains the following plugin(s) that have goals not marked   *
[WARNING] * as @threadSafe to support parallel building.                  *
[WARNING] * While this /may/ work fine, please look for plugin updates    *
[WARNING] * and/or request plugins be made thread-safe.                   *
[WARNING] * If reporting an issue, report it against the plugin in        *
[WARNING] * question, not against maven-core                              *
[WARNING] *****************************************************************
[WARNING] The following plugins are not marked @threadSafe in Apache HBase Shaded Packaging Invariants (with Hadoop bundled):
[WARNING] org.cyclonedx:cyclonedx-maven-plugin:2.7.4
[WARNING] Enable debug to see more precisely which goals are not marked @threadSafe.

beettlle avatar Feb 15 '23 19:02 beettlle

Update: my build was broken. After fixing it the HBase build finished without having to skip CycloneDX but the above warning messages still appear.

beettlle avatar Feb 15 '23 20:02 beettlle