cyclonedx-maven-plugin
cyclonedx-maven-plugin copied to clipboard
cyclonedx-maven-plugin is not marked with @threadSafe run in Multi threaded maven build
From maven build log,
mvn -T 4 clean install
[WARNING] The following plugins are not marked @threadSafe in A-Project: [WARNING] org.cyclonedx:cyclonedx-maven-plugin:2.1.0
+1
I think some investigation needs to be done to determine if the plugin is thread safe or not. I think it is, but if anyone wants to verify that, that would be great.
+1
I'll have a second look at the code to check if I see anything that would prevent the goal to be thread safe...
Implemented in #264. Having to manual close as a bug in GitHub itself prevented the PR from closing and this ticket to be updated as well. Thanks again @hboutemy for confirming the code was thread safe and for putting in the proper Maven flags to indicate such.
FYI @stevespringett : https://issues.apache.org/jira/browse/HBASE-27634 . We're on the latest 2.7.3.
@ndimiduk FYI 2.7.4 is the latest.
@stevespringett I don't think this is working properly even on 2.7.4. To @ndimiduk 's point, this is from my HBase build.
[WARNING] *****************************************************************
[WARNING] * Your build is requesting parallel execution, but project *
[WARNING] * contains the following plugin(s) that have goals not marked *
[WARNING] * as @threadSafe to support parallel building. *
[WARNING] * While this /may/ work fine, please look for plugin updates *
[WARNING] * and/or request plugins be made thread-safe. *
[WARNING] * If reporting an issue, report it against the plugin in *
[WARNING] * question, not against maven-core *
[WARNING] *****************************************************************
[WARNING] The following plugins are not marked @threadSafe in Apache HBase Shaded Packaging Invariants (with Hadoop bundled):
[WARNING] org.cyclonedx:cyclonedx-maven-plugin:2.7.4
[WARNING] Enable debug to see more precisely which goals are not marked @threadSafe.
Update: my build was broken. After fixing it the HBase build finished without having to skip CycloneDX but the above warning messages still appear.