Fix SchemaFactory configuration of XML validator
Coverage summary from Codacy
See diff coverage on Codacy
| Coverage variation | Diff coverage |
|---|---|
| :white_check_mark: +0.08% | :white_check_mark: 100.00% |
Coverage variation details
| Coverable lines | Covered lines | Coverage | |
|---|---|---|---|
| Common ancestor commit (1d9ecdb55b4c0a6b7011dfe27ea9d50177bb274e) | 6456 | 4844 | 75.03% |
| Head commit (af0ec75c93c03f93733a070c5132554490af5314) | 6460 (+4) | 4852 (+8) | 75.11% (+0.08%) |
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>
Diff coverage details
| Coverable lines | Covered lines | Diff coverage | |
|---|---|---|---|
| Pull request (#737) | 4 | 4 | 100.00% |
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%
See your quality gate settings Change summary preferences
have a similar test in the JS lib. see https://github.com/search?q=repo%3ACycloneDX%2Fcyclonedx-javascript-library%20vaiquia2zoo3Im8ro9zahNg5mohwipouka2xieweed6ahChei3doox2fek3ise0lmohju3loh5oDu7eigh3jaeR2aiph2Voo&type=code
@jkowalleck May I ask for a final look please?
LGTM, but I am no actual Java user. Will formally approve to prevent any blockers.
If further review is needed, let me ping some potential reviewers: @DarthHater, @stevespringett, @mr-zepol, @mtsfoni, @hboutemy, @skhokhlov, @glefloch,