cdxgen icon indicating copy to clipboard operation
cdxgen copied to clipboard
verified publisher icon CycloneDX

Strict JSON Schema validation

Open marob opened this issue 1 year ago • 7 comments

marob avatar May 30 '24 15:05 marob

@marob Thank you for this PR. This is a bit more involved than enabling the strict validations. @timmyteo is working on a branch, so best to collaborate with him once he is ready.

prabhu avatar May 30 '24 15:05 prabhu

Hi @marob I have started addressing the related concerns as part of https://github.com/CycloneDX/cdxgen/issues/1107

I have a branch going with the changes and it is close to being completed. But still have a TODO in one code file. Do you want to take over and run with these changes I started as part of this pull request to address all the related issues for this one? https://github.com/CycloneDX/cdxgen/compare/master...timmyteo:cdxgen:feature/issue-1107?expand=1

timmyteo avatar May 30 '24 15:05 timmyteo

Hi @timmyteo. I can try to finish but I'm not sure I'll have time.

marob avatar May 30 '24 16:05 marob

Ok no problem @marob. If you run out of time then let me know.

timmyteo avatar May 30 '24 16:05 timmyteo

@timmyteo Here is what I came up with from your branch: https://github.com/CycloneDX/cdxgen/compare/master...marob:cdxgen:feature/issue-1107

marob avatar May 30 '24 17:05 marob

Changes look great @marob! I like the improvements you made to the original. Very clean. Thanks for your work here.

timmyteo avatar May 30 '24 17:05 timmyteo

I've created this MR that should replace this one.

marob avatar May 30 '24 17:05 marob