assemblyline icon indicating copy to clipboard operation
assemblyline copied to clipboard

Submissions - configuration to filter by default

Open eljeffeg opened this issue 1 year ago • 7 comments

Is your feature request related to a problem? Please describe. Most of my users will want to see their submissions, not all submissions. By default, the submissions goes to all submissions. It would be nice to have it default to the user's filter.

Describe the solution you'd like A default configuration option by the admin (if the default is not filtered), a user defined configuration would be a plus, but not required. When the user clicks submissions, it goes to their submissions. Plus would be if the show my submissions icon was a toggle that stated show all submissions when it was filtered.

Describe alternatives you've considered None

eljeffeg avatar Jan 15 '25 22:01 eljeffeg

We could introduce a preference in the user_settings that users can configure individually to filter to their submissions automatically when going to the Submissions page (the default setting should maintain the status quo).

Optionally, we can change the button to toggle between showing all submissions or only those belonging to the current user (this would involve alternating the tooltip and iconography to make this toggling obvious for the button)

cccs-rs avatar Jan 16 '25 15:01 cccs-rs

Optionally, we can change the button to toggle between showing all submissions or only those belonging to the current user (this would involve alternating the tooltip and iconography to make this toggling obvious for the button)

We could provide this toggling function to the other buttons as well (show completed, show malicious) for filtering as it would appear you could combine filters together by clicking them all.

cccs-rs avatar Jan 16 '25 15:01 cccs-rs

Sounds good !

We could add another Interface option for users to have their submissions shown by default on the Submissions page. The "Show my submissions" button could be a toggle where the tooltip would change between show my submissions and show all submissions.

cccs-nr avatar Jan 16 '25 19:01 cccs-nr

Counter proposal:

Would you be interested in having a "continue where I left off" feature where I would save the latest query in the browser's local storage and load that every time you open the Submission page ? That would save me from adding all the interface configuration.

The default query would still be the same as now and users will have to click the Show my submission button (which I can make it into a toggle).

cccs-nr avatar Jan 20 '25 21:01 cccs-nr

I'm a little concerned that the filter / icons may not be obvious and that the behavior might not be expected to retain filters. What about a ui: filter_on_user: true configuration option that adds ?filters=params.submitter%3A"user" to the left-hand menu Submissions button /submissions url? And the toggle feature..

eljeffeg avatar Jan 21 '25 14:01 eljeffeg

Ok, there's currently a patch in progress for the configuration. I'll wait for that one to be completed and then I'll add the new configuration option for the submission.

cccs-nr avatar Jan 21 '25 17:01 cccs-nr

The latest release of AL changes all action buttons to toggles that add or remove their filter query. Like I said before, the feature to add a configuration option will be done after the submission profile patch will be completed.

cccs-nr avatar Feb 03 '25 23:02 cccs-nr