Vladimir Panteleev

Results 714 comments of Vladimir Panteleev

I think at this point this is part of well-known GitHub culture, is this still worth the vertical space?

I've been in the following situation: - Run into a problem that's solvable by a patch in a D component - Write a patch against the D component and submit...

Yes, I guess that would work for people who do all their work on GitHub, but I think that's not everyone.

> auto-merge + urgent = merge now, whatever the CI status is? (may be useful when we need to do an urgent revert or the CIs are broken at the...

@andralex At Facebook how often did you have submitters and reviewers in drastically different time zones?

> Code reviews should not ask for overengineering the trivial. They should not hold code hostage on a matter of preference of the reviewer. The reviewers should exercise good judgment...

Mmm, don't think so, sorry. Missing a way to find a full list of PRs which included revert commits.

> Overall anything that's reasonable complex intrinsically requires enough time to be reviewed anyhow, Yep, but this idea is not about those cases. We have: - really trivial PRs that...

Is this still relevant today, now that we have staff reviewing PRs?