DFeed icon indicating copy to clipboard operation
DFeed copied to clipboard

If Name starts with "<" then the mail address is partially displayed

Open ghost opened this issue 7 years ago • 4 comments

Here https://forum.dlang.org/post/[email protected]. The user name used was <Lesser_name and the user address used was [email protected] But something strange is displayed instead of <Lesser_name there's Lesser_name <address

ghost avatar Oct 23 '18 12:10 ghost

From: <lesser_name <[email protected]>

That doesn't look valid. The server shouldn't have accepted it.

CyberShadow avatar Oct 23 '18 12:10 CyberShadow

https://tools.ietf.org/tools/msglint/ says:

ERROR: at least one mailbox required at or before token '<' in header 'From' 
       at line 2
ERROR: unexpected tokens at end of header 'From' at line 2
ERROR:  Token type       special: <
ERROR:  Token type          atom: address
ERROR:  Token type       special: @
ERROR:  Token type          atom: somewhere
ERROR:  Token type       special: .
ERROR:  Token type          atom: org
ERROR:  Token type       special: >

CyberShadow avatar Oct 23 '18 12:10 CyberShadow

We can fix DFeed from emitting such messages, but we can't fix others sending such malformed messages via email/NNTP..

CyberShadow avatar Oct 23 '18 12:10 CyberShadow

DFeed's header parsing is really ad-hoc and needs a rewrite. I'll have to get back to this later, probably port the test messages from my Windows installation's hard drive to real unit tests first.

CyberShadow avatar Oct 23 '18 14:10 CyberShadow