cbj_app icon indicating copy to clipboard operation
cbj_app copied to clipboard

Not all of the app support translation

Open guyluz11 opened this issue 3 years ago • 9 comments

There is a big part of the app that does not support translation.

For the app to support translation there are 3 things that need to be added for each text string:

  1. Importing the easy_localization dependency import 'package:easy_localization/easy_localization.dart';
  2. Adding .tr() after the text string, for example 'hey' going te become 'hey'.tr(), and if this is Text widget it is also supported like this Text('Text support translation').tr().
  3. Add the new English translation key and value in the en-US.json.
  • Most of the string that needs to be added exists in the presentation folder so you can filter by it.

  • It is ok to do a partial pull request and not all add translations for everything at once.

guyluz11 avatar Oct 07 '21 13:10 guyluz11

@guyluz11 Can I work on this issue?

superiorsd10 avatar Oct 01 '22 08:10 superiorsd10

Yep

guyluz11 avatar Oct 01 '22 08:10 guyluz11

Thanks for the pr.

guyluz11 avatar Oct 01 '22 16:10 guyluz11

You're most welcome :)

superiorsd10 avatar Oct 01 '22 16:10 superiorsd10

Please assign this to me

piyushkumar12111111 avatar Oct 04 '22 17:10 piyushkumar12111111

@piyushkumar12111111 sure :)

guyluz11 avatar Oct 04 '22 17:10 guyluz11

Hi @piyushkumar12111111 I am removing you from Assignees but your pr will still be merged if it will be accepted

Thanks

guyluz11 avatar Oct 08 '22 13:10 guyluz11

Hello, please assign this to me

mufida1018 avatar Oct 08 '22 16:10 mufida1018

Just open pr for that @mufida1018 :) for now we may assign only big issues

guyluz11 avatar Oct 08 '22 16:10 guyluz11