XbSymbolDatabase
XbSymbolDatabase copied to clipboard
Use of non-static variables and functions
There's many cases of non-static variables in the source-code:
https://github.com/Cxbx-Reloaded/XbSymbolDatabase/blob/6820d3f74afed86b2b34810590f46ce95420755b/XbSymbolDatabase.c#L1617
https://github.com/Cxbx-Reloaded/XbSymbolDatabase/blob/6820d3f74afed86b2b34810590f46ce95420755b/XbSymbolDatabase.c#L1622
...
This also includes all of the OOVPA, which appear to use non-static variables via OOVPA_XREF
:
https://github.com/Cxbx-Reloaded/XbSymbolDatabase/blob/6820d3f74afed86b2b34810590f46ce95420755b/OOVPA.h#L136-L140
This pollutes the object files with many symbols with limited use-cases. It also hints to the compiler that it shouldn't optimize these functions as they could be called differently.
The project should probably only use non-static for what's found in XbSymbolDatabase.h