Customies icon indicating copy to clipboard operation
Customies copied to clipboard

Fix GlintComponent name and reorder RecordComponent constructor

Open khIbrahim opened this issue 5 months ago • 4 comments

glint wasn’t showing, record was causing some gray error in console (param order mismatch i think)

changed glint getName to "minecraft:glint"
switched record constructor param order (duration first)

thanks 👍

khIbrahim avatar Jul 16 '25 18:07 khIbrahim

Did you test these out?

jeantkg avatar Jul 20 '25 10:07 jeantkg

yes glint seems working with "minecraft:glint" and "glint" mb. And the most important thing here is the eorder RecordComponent constructor cause i've had some Deprecated errors on the console

khIbrahim avatar Jul 20 '25 10:07 khIbrahim

yes glint seems working with "minecraft:glint" and "glint" mb. And the most important thing here is the eorder RecordComponent constructor cause i've had some Deprecated errors on the console

It looks like they changed the glint component in the new update to finally use minecraft:glint, but I don't know about the RecordComponent

jeantkg avatar Jul 20 '25 10:07 jeantkg

I noticed the warning: Deprecated: Optional parameter $comparatorSignal declared before required parameter $duration...

That deprecation warning was kinda annoying, just reordered the params and it's all good now I think it only shows up with some PHP libs or versions because I had my php error reporting on showing depreacted errors, and i think im not the only one, but better to fix it anyway

khIbrahim avatar Jul 20 '25 10:07 khIbrahim