CurlyMoo

> Which test is missing? Here various parameters are set, but the test doesn't check if they are all set with the correct values: https://github.com/pilight/pilight/pull/434/files#diff-37f44c5e034922929cf9d82ace01b336R323 > The frequency is checked...

> The rfmcfg are hardcoded values for the RFM69 IC. Is it really needed to check for it? When the SPI is working, which is checked implicitely with RX/TX tests,...

So what happens when i do the following: ``` for(i=0;i

But where are those values defined at the unit test side? I only see that empty struct.

That's what I said. At the hardware side not at the unit test side. Also, the new implementation will be in lua so the c defined struct of the module...

> Ok, this means the rfmcfg needs to be defined redundant also in the unittest. Welcome to the world of unittesting 😉

I've ported the whole module to lua and all unittest succeed. You can check the work done in the `raspyrfm` repository. If the module doesn't work in real life, then...

pilight programs are not supported in the rewrite branch. That's why i removed them in the latest commits.

Also, welcome back 👍

Would be indeed great to get this into the new staging branch. Let's just update this PR.