CurlyMoo

Quite a good PR if i must say. Can you do another PR against the rewrite branch as well, accompanied with a decent unittest?

Great how you rebase each commit 👍 If just all PR's were like this.

The post you requested too was: https://forum.pilight.org/showthread.php?tid=3252&pid=24003#pid24003 Where you replied to the: > You should follow the contribution guide. That's enough. But you obviously didn't.

Please don't close PR's but fix them.

You are able to use git and open a PR, so you can probably do more than you think of 😄 Allow us to help you to fix it. And...

Any news?

Did you have a second PR against the rewrite branch with a unittest as well?

The current PR is fine as far as i have taken a look at it. However, i want a second PR with unittests that i will merge first.

Please read the contribution guide.

Finally, RaspyFM 👍 Can you change the license to MPLv2? Also, you do have the posibility to make a unit test for it as well on the rewrite branch?