cubiomes icon indicating copy to clipboard operation
cubiomes copied to clipboard

fix: compute bastion variants correctly for 1.16.1

Open alex-chew opened this issue 2 years ago • 1 comments

In Minecraft 1.16.1, a bastion's variant is sampled from its ChunkRandom before its rotation is sampled, not the other way around (as is so for 1.16.2 and above). I tested this on 10 or so bastions in 1.16.1 versus 1.16.2, and this PR fixes the computed bastion variants for 1.16.1.

alex-chew avatar Jul 18 '22 02:07 alex-chew

Thanks, but unfortunately I don't have the time or motivation to support each minor version, which is why cubiomes only supports the latest patch of each major version. Minor patches actually change things like that fairly frequently, and supporting 1.16.1 without all the other minor patches of all versions doesn't make too much sense.

Cubitect avatar Jul 29 '22 17:07 Cubitect

Some groundwork has now been done to support minor versions and, although the development focus will remain with the latest patch for each major release, this Bastion rotation fix is now included.

Cubitect avatar Jan 16 '23 19:01 Cubitect

Thanks, glad to hear it!

alex-chew avatar Jan 19 '23 08:01 alex-chew