cubiomes-viewer icon indicating copy to clipboard operation
cubiomes-viewer copied to clipboard

Segmentation fault on biome search

Open maxsupermanhd opened this issue 2 years ago • 3 comments

I want to find some mushroom islands on my seed but upon entering search parameters and clicking on "Analyze" I get segfault.

Steps to reproduce:

  1. Enter seed 7540332306713543803, version 1.12
  2. Set Y to 256 (same with Y63)
  3. Navigate to biomes tab, set current seed and search space -100k, -100k, 100k, 100k
  4. In locate subtab select mushroom fields, area of 128 with 0 border tolerance
  5. Click on analyze and get segfault

Linux Ubuntu 20.04 Compiled from master f8c7ca6 in clean build directory

maxsupermanhd avatar Jan 24 '23 13:01 maxsupermanhd

The locate function is not really equipped to handle areas that exceed the signed integer limit in size. It definitely shouldn't crash though and the next version will guard for this and show an appropriate warning.

Cubitect avatar Jan 24 '23 20:01 Cubitect

What about making another function that would operate on int64? Or is it just viewer-specific code? (I don't want to be a reason for breaking changes in cubiomes :stuck_out_tongue:)

maxsupermanhd avatar Jan 25 '23 06:01 maxsupermanhd

Can confirm, version 3.2.1 win10 x64 downloaded from https://github.com/Cubitect/cubiomes-viewer/releases.

0x000006 avatar Feb 21 '23 13:02 0x000006