Modern-Warfare-Cubed icon indicating copy to clipboard operation
Modern-Warfare-Cubed copied to clipboard

[DEV] Reloading magazines in creative crashes the game

Open Desoroxxx opened this issue 1 year ago • 3 comments

Describe the bug

When reloading a magazine in creative it crashes the game due to a NPE.

Fairly sure when I improved the creative reload, I forgot a check for instance or something?

Reproducibility

  • [X] I reproduced this issue with as few other mods as possible installed.
  • [ ] I am unable to reproduce this issue consistently.

Screenshots and/or videos

No response

Logs

https://mclo.gs/BOFHF7i

MWC Version

MWC 0.2 Dev 4

Forge Version

1.12.2 - 14.23.5.2860

Red Core Version

0.6 Dev 8

MixinBooter Version

10.2

Java Version

8 - 371

Java Virtual Machine

Hotspot

Operating System

Windows 11

GPU Vendor

NVIDIA

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

Desoroxxx avatar Dec 05 '24 21:12 Desoroxxx

Thanks to azimuthxzaxis on Discord for reporting this issue

Desoroxxx avatar Dec 05 '24 21:12 Desoroxxx

I get a crash when i hold a mag.

adding a null check here prevents the crash, but breaks all of the nice work @Paneedah did with the HUD way back when image

The HUD doesn't render 2024-12-08_17 35 01

(For future ref this is line 249 of HUD.java)

strubium avatar Dec 08 '24 23:12 strubium

Oh I didn't push the fix? Welp guess it will wait until I am back

Desoroxxx avatar Dec 09 '24 14:12 Desoroxxx

@Desoroxxx Did you ever push this fix?

strubium avatar Oct 20 '25 14:10 strubium

@Desoroxxx Did you ever push this fix?

Pretty sure, would need to confirm before closing the issue

Desoroxxx avatar Oct 20 '25 16:10 Desoroxxx