AMPTemplates icon indicating copy to clipboard operation
AMPTemplates copied to clipboard

Updated Seven days to die to 1.0 config

Open Xentraxx opened this issue 1 year ago • 6 comments

Tested and working.

Xentraxx avatar Aug 03 '24 14:08 Xentraxx

Really needed to make all the unnecessary whitespace changes? Lol

Greelan avatar Aug 07 '24 11:08 Greelan

Really needed to make all the unnecessary whitespace changes? Lol

VS Code auto formatting goes brr

Xentraxx avatar Aug 07 '24 12:08 Xentraxx

@Greelan I think this Template is kind of a mess because of all the different versions it tries to handle. I believe it's quite confusing. Like which setting to use for which version. What do you think about creating a completely new template "Seven days to die" and renaming the other one to something along the lines "Seven days to die pre-release", to have a new start and a fresh and tidy template?

Xentraxx avatar Aug 10 '24 17:08 Xentraxx

Rather than that I think it'd be better to just put the settings into a different subcategory.

IceOfWraith avatar Aug 10 '24 17:08 IceOfWraith

I've got a pending PR for the new subcatetories, but I don't want this PR accepted with the formatting changes showing it as "Whole files removed/while files added" because it makes it impossible to review the changes.

PhonicUK avatar Aug 13 '24 13:08 PhonicUK

If you can fix the spacing to 4 spaces in the JSON files I'll review this one. As is, it's too messy and doesn't match the formatting of others. There's a setting in VS that adjusts this.

IceOfWraith avatar Sep 25 '24 13:09 IceOfWraith

I tried, but even though I changed the settings in VS code and the files look fine for me, VS code does not recognize this change as a change of the file, so apparently I can't save it.

Xentraxx avatar Oct 15 '24 18:10 Xentraxx

@IceOfWraith I have included some spacing fixes that should make it easier to review

Greelan avatar Oct 19 '24 07:10 Greelan

Thank you! I'll look over it.

IceOfWraith avatar Oct 19 '24 07:10 IceOfWraith

Tho now there are conflicts due to the previous reconfiguration of the settings categories/subcategories.

Might be easier for the OP to start over tbh

Greelan avatar Oct 19 '24 07:10 Greelan