Steamcmd update stage being skipped when fails

[southnode]

Bug Report

Steamcmd update stage being skipped when fails

System Information

• Operating System (Including distribution name and version number) N/A
• AMP version and build date (Always use the version number, 'latest' is not valid!) 2.4.1.2 Mainline
• Which AMP release stream you're using (Mainline, Nightly or FastTrack) Mainline

I confirm:

• [x] that I have searched for an existing bug report for this issue.
• [x] that I am using the latest available version of AMP.
• [x] that my operating system is up-to-date.

Symptoms

• What are you trying to do? Install using steamcmd
• What are you expecting to happen? If steamcmd fails, don't try to start the server
• What is actually happening? ('Nothing' is not an acceptable answer!) It tries to start the server over and over again, failing constantly, putting itself into a loop and freezing the instance.

[Greelan]

The issue is not necessarily that SteamCMD fails. It is that AMP does not pause the stage while the login credentials (username, password, steamguard code) are entered.

In your case that has severe consequences because the next update stage is Start server, which obviously breaks because the server hasn't been installed yet - and AMP tries updating over and over again. In other cases a following update stage fails because the server directories haven't yet been created (again because the SteamCMD update stage hasn't finished) and so eg a config download to a server directory also fails. Just not so spectacularly.

[PhonicUK]

Fixed in CI. It only affected certain types of update stages that AMP handled as long-running tasks rather than something that was expected to return immediately. The exact same issue was causing bugs with pre-start tasks too. Both have been fixed in CI.

[Greelan]

This change appears to have resulted now in the subsequent update stages not being run at all.

I noticed that when the prompt for Steam login credentials appears, the SteamCMD stage notification in the background disappears rather than remaining open. Maybe that is an indication of how AMP is now treating the stage.

[MrSmits]

I've created a new issue, as technically the steamcmd stage itself runs just fine in nightly https://github.com/CubeCoders/AMP/issues/835

[Greelan]

I've created a new issue, as technically the steamcmd stage itself runs just fine in nightly #835

Except in docker on Linux, where another AMP bug involving the use of numactl prevents SteamCMD from being run at all. Anyway, Valve has just updated SteamCMD and fixed the previous bug they introduced, meaning numactl should not need to be used.

[Greelan]

This issue should be re-opened, as the bug remains/has re-emerged. Update stages that follow a steamcmd stage that requires login, fail. It seems they are run immediately after the SteamCMD stage is waiting for auth, and are not run after the SteamCMD stage is successfully completed - which is arse backwards

[IceOfWraith]

I've also verified.

[PhonicUK]

Can I get an example of a game where this happens?

[IceOfWraith]

I believe this was fixed in the last few months. @Greelan can you verify if you're still seeing it happen?

[Greelan]

I don't think I have noted specifically this issue recently, though the update stage logic still has quirks and anomalies

[IceOfWraith]

I'll close this one then and one of us can make a new one with what's going on there. If you let me know on Discord what you're seeing I'll write it up. I'm sure I've seen it too, but there's a lot to keep track of in all of these issues. Lol