AMP icon indicating copy to clipboard operation
AMP copied to clipboard

Published 20 hours ago • verified publisher icon CubeCoders

Meta.ContainerPolicy = NotSupported Doesn't Work

Open IceOfWraith opened this issue 2 years ago • 2 comments

Bug Report

System Information

  • Operating System - Ubuntu 22.04 LTS Controller / Ubuntu 22.04 LTS Target or Windows 11 Pro Target
  • AMP version and build date - v2.4.0.6, built 27/09/2022 12:41
  • Which AMP release stream you're using - Nightly

I confirm:

  • [x] that I have searched for an existing bug report for this issue.
  • [x] that I am using the latest available version of AMP.
  • [x] that my operating system is up-to-date.

Symptoms

  • What are you trying to do? Not create an instance.

  • What are you expecting to happen? AMP should stop me from creating an instance in a container when the ContainerPolicy is set to NotSupported.

  • What is actually happening? ('Nothing' is not an acceptable answer!) It happily creates a container and laughs at my face.

Reproduction

Make an instance that has "NotSupported" as the policy (currently none set to this).

IceOfWraith avatar Sep 28 '22 02:09 IceOfWraith

Does it also still recommend that the instance is created in a container, like Supported does?

Greelan avatar Sep 28 '22 03:09 Greelan

Thankfully, no its doesn't. It has no message.

IceOfWraith avatar Sep 28 '22 03:09 IceOfWraith

Implemented in CI, it now shows that this isn't supported if the target is configured to use containers with the usual configurable message.

PhonicUK avatar Dec 13 '22 17:12 PhonicUK

The implemented solution is too aggressive. It stops an instance being created even if New Instance Defaults has Create in Docker Containers set to False.

AMP should only stop an instance being created if, by doing so, it would be created in a Docker container.

This affects the Stationeers template, given that currently the server cannot run in Docker (as Debian 11's version of glibc is too old).

Greelan avatar Jan 09 '23 12:01 Greelan

That might just be a caching thing, the current logic is:

self.selectedTarget().createsInContainers() && self.selectedApplication().ContainerSupport() == 1

So if the selected target creates in containers and ContainerSupport is Unsupported, then it doesn't allow it.

At which stage exactly is it stopping you from creating the instance?

PhonicUK avatar Jan 11 '23 14:01 PhonicUK

Immediately after clicking + to create a new Stationeers instance. See for yourself.

Greelan avatar Jan 11 '23 20:01 Greelan