AMP icon indicating copy to clipboard operation
AMP copied to clipboard
verified publisher icon CubeCoders

RCONConnected Ready Mode in Generic Configs do not clear the notification

Open IceOfWraith opened this issue 3 years ago • 2 comments

Bug Report

System Information

  • Operating System Windows 11 Pro
  • AMP version and build date: v2.3.2, built 07/02/2022 23:57
  • Which AMP release stream you're using: CI Build

I confirm:

  • [x] that I have searched for an existing bug report for this issue.
  • [x] that I am using the latest available version of AMP.
  • [x] that my operating system is up-to-date.

Symptoms

  • What are you trying to do? Use RCONConnected on a generic config for DayZ.

  • What are you expecting to happen? After the connection is made, the notification in the bottom right should clear.

  • What is actually happening? RCON connects as expected now, and the buttons at the top change to "Restart" and "Stop" as expected, but the notification never clears.

Reproduction

Load the DayZ WIP module with RCON configured and it will happen during server start.

RCON Issue

IceOfWraith avatar Feb 13 '22 01:02 IceOfWraith

Workaround for now is to enable fast startup, but I'll look into this.

PhonicUK avatar Feb 21 '22 16:02 PhonicUK

Retest required.

PhonicUK avatar Jul 26 '22 16:07 PhonicUK

Bumping this. Surely this is a simple fix - ie as soon as the Running state is reached the notification is cleared? Presumably similar logic to other startup modes?

Greelan avatar Nov 27 '22 21:11 Greelan

Bumping this. Surely this is a simple fix - ie as soon as the Running state is reached the notification is cleared? Presumably similar logic to other startup modes?

That's exactly how it works: image

I've not been able to reproduce this in CI as a result. So I'll close this for now.

PhonicUK avatar Dec 14 '22 16:12 PhonicUK

Did you actually try it or just verify the code? I don't believe any templates currently use this start mode because it doesn't work right.

IceOfWraith avatar Dec 14 '22 16:12 IceOfWraith

@PhonicUK You're welcome to try the WIP ARK template in my dev branch, which uses this mode and which is where I see the behaviour. Greelan/AMPTemplates:dev

I have also observed it previously when playing with different start modes on other templates. As has Ice. So there is clearly something wrong with the code.

Greelan avatar Dec 14 '22 19:12 Greelan

Righto, I've put together new unit tests to help validate the behaviour based on different scenarios so I'll check that it works with your config, but after that testing it should be fine already. I've made some other changes to how sleep mode works though that I'll need to document.

PhonicUK avatar Dec 14 '22 19:12 PhonicUK

In reality you could just use any generic template that uses RCON for AMP's console and switch the start mode to RCONConnected to test this.

Greelan avatar Dec 15 '22 07:12 Greelan