AMP icon indicating copy to clipboard operation
AMP copied to clipboard

Hidden Generic Settings Show in Search Results

Open IceOfWraith opened this issue 1 year ago • 6 comments

Operating System

Ubuntu 24.04

AMP Version and Build Date

2.6.0.6

AMP Release Stream

Mainline

I confirm that

  • [X] I have searched for an existing bug report for this issue.
  • [X] I am using the latest available version of AMP.
  • [X] my operating system is up-to-date.

Intended Action

N/A

Expected Behaviour

N/A

Actual Behaviour

N/A

Reproduction

Hidden settings shouldn't show in search results.

IceOfWraith avatar Nov 30 '24 06:11 IceOfWraith

Fixed in dev. Fields with the HIDDEN input type won't show in search results any more.

PhonicUK avatar Dec 16 '24 15:12 PhonicUK

That's not the correct solution.

"InputType": "hidden" should still show, as they give info in the UI

"Hidden": true are the settings that should not be searchable

Greelan avatar Dec 16 '24 19:12 Greelan

Surely hidden input types shouldn't show in search results though because it's meant to search changeable settings rather than descriptions? Hidden: true is internally implemented though using AMPs readonly flag which is what it should (also) be filtering out.

PhonicUK avatar Dec 16 '24 21:12 PhonicUK

They're visible in the UI and used to point users to other areas when needed. So the search is useful for hidden input types.

IceOfWraith avatar Dec 16 '24 21:12 IceOfWraith

This ^. They are most often used as an "info box" so searchability is useful (and assumed)

Greelan avatar Dec 16 '24 21:12 Greelan

And "Hidden": true settings are not currently being filtered, which is what this bug issue is about

Greelan avatar Dec 16 '24 21:12 Greelan

It looks like this was addressed already. Not seeing hidden settings in results now. Let me know if you see differently.

IceOfWraith avatar Jul 27 '25 06:07 IceOfWraith