Hidden Generic Settings Show in Search Results
Operating System
Ubuntu 24.04
AMP Version and Build Date
2.6.0.6
AMP Release Stream
Mainline
I confirm that
- [X] I have searched for an existing bug report for this issue.
- [X] I am using the latest available version of AMP.
- [X] my operating system is up-to-date.
Intended Action
N/A
Expected Behaviour
N/A
Actual Behaviour
N/A
Reproduction
Hidden settings shouldn't show in search results.
Fixed in dev. Fields with the HIDDEN input type won't show in search results any more.
That's not the correct solution.
"InputType": "hidden" should still show, as they give info in the UI
"Hidden": true are the settings that should not be searchable
Surely hidden input types shouldn't show in search results though because it's meant to search changeable settings rather than descriptions? Hidden: true is internally implemented though using AMPs readonly flag which is what it should (also) be filtering out.
They're visible in the UI and used to point users to other areas when needed. So the search is useful for hidden input types.
This ^. They are most often used as an "info box" so searchability is useful (and assumed)
And "Hidden": true settings are not currently being filtered, which is what this bug issue is about
It looks like this was addressed already. Not seeing hidden settings in results now. Let me know if you see differently.