AMP icon indicating copy to clipboard operation
AMP copied to clipboard

Modifications to existing entries in default instance settings do not persist

Open FrozenSoda opened this issue 1 year ago • 5 comments

Bug Report

System Information

Operating System

Ubuntu Server 22.04.4

AMP Version and Build Date

2.5.0.8 - 20240502.1

AMP Release Stream

Mainline

I confirm:

  • [x] that I have searched for an existing bug report for this issue.
  • [x] that I am using the latest available version of AMP.
  • [x] that my operating system is up-to-date.

Symptoms

What are you trying to do?

Edit an existing entry in Configuration > New Instance Defaults > Default Settings.

What are you expecting to happen?

That the changes are saved.

What is actually happening?

The node and value gets reset after refreshing the page, even if you attempt to save your changes by pressing enter or clicking outside the textbox.

Reproduction

  1. Go to Configuration > New Instance Defaults > Default Settings.
  2. Edit any field under Node or Value. For example try to change the value of Core.Privacy.AllowAnalytics to false.
  3. Refresh the page by pressing F5.
  4. Navigate to Default Settings again and observe that the changes were not saved.

FrozenSoda avatar May 05 '24 14:05 FrozenSoda

After entering the key and value, did you press + at the right?

Greelan avatar May 05 '24 20:05 Greelan

After entering the key and value, did you press + at the right?

When modifying an existing entry, there is only the X button to delete it.

FrozenSoda avatar May 05 '24 20:05 FrozenSoda

That's because there is no ability to edit existing entries atm. Has been requested

Greelan avatar May 05 '24 20:05 Greelan

That's because there is no ability to edit existing entries atm. Has been requested

Oh, okay. Maybe the textboxes should be readonly in the meantime to prevent confusion

FrozenSoda avatar May 05 '24 20:05 FrozenSoda

This has been addressed in a subsequent update.

PhonicUK avatar Jun 04 '24 18:06 PhonicUK

This has been addressed in a subsequent update.

The issue does not seem to be fixed, it is still present on AMP version 2.5.1.6 - 20240816.1. But maybe you mean that a fix has been made but not yet released?

FrozenSoda avatar Aug 25 '24 20:08 FrozenSoda