panel icon indicating copy to clipboard operation
panel copied to clipboard

feat: 2FA Progress Sync

Open AGuyNamedJens opened this issue 1 year ago • 10 comments

Managed to get 2FA integration working, it yet has to be connected to the actual login method for users. Feel free to debug, change it or whatever. Basics are implemented.

See: app/Http/Controllers/Auth/Login2FAController.php app/Http/Controllers/LoginCheckpointController.php app/Http/Controllers/Kernel.php app/Http/Models/RecoveryToken.php app/Http/Models/User.php database/UserFactory.php routes/web.php themes/default/views/auth/2fa-secret.blade.php composer.json

For my changes

AGuyNamedJens avatar Dec 10 '23 21:12 AGuyNamedJens

How would it links to ptero 2fa?

GeekCornerGH avatar Dec 11 '23 11:12 GeekCornerGH

How would it links to ptero 2fa?

I don't have enough knowledge about how Pterodactyl does it, I honestly don't think we can just hook into their 2FA system because that can basically beat the whole security logic of 2FA

AGuyNamedJens avatar Dec 17 '23 13:12 AGuyNamedJens

How would it links to ptero 2fa?

I don't have enough knowledge about how Pterodactyl does it, I honestly don't think we can just hook into their 2FA system because that can basically beat the whole security logic of 2FA

yeah please don't what would the point be then?

sybetjeh avatar Dec 23 '23 15:12 sybetjeh

no update since 2023 ?

S0ly avatar May 04 '24 09:05 S0ly

no update since 2023 ?

Feel free to provide your own update, I'm clueless at this point which is why I request other contributions to join in

AGuyNamedJens avatar May 04 '24 10:05 AGuyNamedJens

I tried to resolve the conflict that was whit .gitignore hope I didnt missed anything

S0ly avatar May 17 '24 12:05 S0ly

what we do of this pull request since its totally inactive and not finished ?

S0ly avatar Jun 13 '24 22:06 S0ly

@IceToast @1day2die

S0ly avatar Jun 17 '24 12:06 S0ly

what we do of this pull request since its totally inactive and not finished ?

I guess no one wants it implemented? I got stuck at the moment of login methods, as previously discussed it's due to how we still depend on Laravel/ui which makes integration impossible with 2FA

AGuyNamedJens avatar Jun 19 '24 09:06 AGuyNamedJens

personally it would be interesting me to have this but its not currently on my priority list :) and I dont know how to help whit it

S0ly avatar Jun 19 '24 09:06 S0ly

we should close the PR if no one is gonna do it, it will be available for reopen later

S0ly avatar Jul 24 '24 14:07 S0ly

we should close the PR if no one is gonna do it, it will be available for reopen later

I agree.

AGuyNamedJens avatar Jul 24 '24 14:07 AGuyNamedJens