panel icon indicating copy to clipboard operation
panel copied to clipboard

Published 20 hours ago • verified publisher icon Ctrlpanel-gg

feat: Add readable name to permissions

Open Ferks-FK opened this issue 1 year ago • 19 comments

Add friendly names for role permissions.

This needs a refactoring of the way permissions are checked on controllers.

Ferks-FK avatar Sep 17 '23 15:09 Ferks-FK

is this still up to date ?

S0ly avatar May 15 '24 12:05 S0ly

I cant resolve the conflict and I cant determine the priority of this feature

S0ly avatar May 17 '24 13:05 S0ly

I cant resolve the conflict and I cant determine the priority of this feature

its a huge step for user friendliness

1day2die avatar May 17 '24 23:05 1day2die

so its a medium or high priority ?

S0ly avatar May 17 '24 23:05 S0ly

should be resolved?

1day2die avatar May 17 '24 23:05 1day2die

not tested at all

1day2die avatar May 17 '24 23:05 1day2die

so its a medium or high priority ?

medium

1day2die avatar May 17 '24 23:05 1day2die

and what need to be done for it to be merged ?

S0ly avatar May 17 '24 23:05 S0ly

@Ferks-FK

1day2die avatar May 17 '24 23:05 1day2die

ferk told me on discord that he didnt remembered :(

S0ly avatar May 17 '24 23:05 S0ly

and what need to be done for it to be merged ?

I think my original plan was to use laravel Policies on the controller side

Ferks-FK avatar May 18 '24 01:05 Ferks-FK

so what we do of this PR ? @Ferks-FK will you finish it ? what is it used for because the description is very vague

S0ly avatar May 22 '24 23:05 S0ly

so what we do of this PR ? @Ferks-FK will you finish it ? what is it used for because the description is very vague

It can be merged as it is (needs testing), taking into account that the development branch needs to be tested as a whole.

Ferks-FK avatar May 23 '24 01:05 Ferks-FK

@Ferks-FK im confused by the files, can you more explain what is going on what are the change and what they do ? and deactivate the draft mode of the PR if you think it can be merged thanks !

S0ly avatar Jun 13 '24 22:06 S0ly

any news ?

S0ly avatar Jun 17 '24 07:06 S0ly

@Ferks-FK im confused by the files, can you more explain what is going on what are the change and what they do ? and deactivate the draft mode of the PR if you think it can be merged thanks !

I commented that this would need a refactoring in the way permissions are checked in the backend, but this can easily be done in another PR, because it would take a lot of changes. So I'll open this PR, and it could be merged.

Ferks-FK avatar Jun 17 '24 12:06 Ferks-FK

okay @IceToast need you :)

S0ly avatar Jun 17 '24 12:06 S0ly

why you don't merge it ? :)

S0ly avatar Jun 23 '24 18:06 S0ly

This PR has conflicts with development. @Ferks-FK can you fix them in order to merge the PR?

IceToast avatar Jun 24 '24 21:06 IceToast