panel icon indicating copy to clipboard operation
panel copied to clipboard

[Bug]: Server name missing in notifications

Open GeckoBoy84 opened this issue 2 years ago • 6 comments

What is your request about?

Server name is not included in suspend notifications

Branch

main

Solution idea

Add the server name to suspend notifications

Controlpanel Logs

No response

Additional Info

No response

GeckoBoy84 avatar May 12 '23 09:05 GeckoBoy84

this is the case because once a user runs out of credits ALL servers get suspended obviously.

We have to keep this in mind thought and have to re-check the suspension logic because of the new billing cycles @IceToast

1day2die avatar May 12 '23 09:05 1day2die

Not necessarily, all servers get suspended that cannot be paid for, but if they are cheaper you might last another few billing periods. Additionally you currently #246 get an email for each service so there is no way to differentiate between them

GeckoBoy84 avatar May 12 '23 09:05 GeckoBoy84

With the new billing cycle each server must get suspended individually and thus sending a individual mail and/or notification

IceToast avatar May 17 '23 13:05 IceToast

and so have this been fixed in the dev branch ?

S0ly avatar May 15 '24 14:05 S0ly

@IceToast please

S0ly avatar Jun 24 '24 13:06 S0ly

Nope it hasnt been fixed yet. The app/Notifications/ServersSuspendedNotification.php handles the notification with a generic "All servers" since back then all servers have been suspended without the period system.

This could be done easily tho. Adding a prop to the notification and hand over the server name/id to the notification handler: app\Console\Commands\ChargeServers.php:131

IceToast avatar Jun 24 '24 21:06 IceToast