panel icon indicating copy to clipboard operation
panel copied to clipboard

Remove Salutation and Closing from email notification

Open ok236449 opened this issue 3 years ago • 17 comments

When you send a notification on the dashboard, you may face the issue of doubling these.

Steps to reproduce the behavior: Let's say, you want to notify a user by both email and dashboard notifications. You create a notification something like this: 1 On dashboard, the notification would be sent normally, just like you wrote it. 2 The mail would have 2 salutations and 2 closings. 3

Expected behavior The automatic salutation and closing should be removed from these notification emails, but kept on the other mails(reset password, ...)

Adding the salutation to dashboard notifications would work, but that is not the best way of fixing this. Removing the salutation from mail is a way better idea as it allows for customizability and if you were to notify someone, you would definitely write them on your own.

ok236449 avatar Feb 06 '22 12:02 ok236449

have this been fixed since ?

S0ly avatar May 18 '24 01:05 S0ly

No

GeckoBoy84 avatar May 19 '24 16:05 GeckoBoy84

Am I missing something? I see in the message only the text that you wrote. Or do you mean to completely remove the greeting and ending from the email template for notifications?

MrWeez avatar May 22 '24 20:05 MrWeez

idk if you can test if the issues is still here so we can ethier fix or close this issue it could be great @MrWeez ! :)

S0ly avatar May 22 '24 20:05 S0ly

idk if you can test if the issues is still here so we can ethier fix or close this issue it could be great @MrWeez ! :)

Although, I have an idea. We can add a greeting to the notification template in the dashboard.

MrWeez avatar May 22 '24 20:05 MrWeez

Then we won't have to write a greeting in the notification text.

MrWeez avatar May 22 '24 21:05 MrWeez

what ? there is just no need for a greeting why a "hello" is by default and non removable in the template ? xD

S0ly avatar May 22 '24 21:05 S0ly

I dont have working mail so I cannot check but the hello just need to be removed

S0ly avatar May 22 '24 21:05 S0ly

like it make no sense to use a template on a custom mail

S0ly avatar May 22 '24 21:05 S0ly

like it make no sense to use a template on a custom mail

Ok, I will try to solve this problem. I'll assign myself for now so I don't forget.

MrWeez avatar May 22 '24 21:05 MrWeez

it should be pretty easy to fix I just dont have time for it since it a medium priority and I cannot test it but yeah fixing it should be easy and nice to not have this problem thanks weez :)

S0ly avatar May 22 '24 21:05 S0ly

it should be pretty easy to fix I just dont have time for it since it a medium priority and I cannot test it but yeah fixing it should be easy and nice to not have this problem thanks weez :)

If you want, I can give you an smtp account for testing xD

MrWeez avatar May 22 '24 21:05 MrWeez

no thanks weez xD

S0ly avatar May 22 '24 21:05 S0ly

no thanks weez xD

I couldn't get the job off on you 😂😂

MrWeez avatar May 22 '24 21:05 MrWeez

weez you dont feel I have enough pressure on me ? xD

S0ly avatar May 22 '24 21:05 S0ly

weez you dont feel I have enough pressure on me ? xD

I'm kidding. You already have a lot of tasks

MrWeez avatar May 22 '24 21:05 MrWeez