better-ffmpeg-progress icon indicating copy to clipboard operation
better-ffmpeg-progress copied to clipboard

Exists file alert

Open mammothrider opened this issue 1 year ago • 2 comments

The ffmpeg alert "File 'xxx' already exists. Overwrite? [y/N]" is hidden by the progress bar, but can still press y and pass it.

Maybe show this alert before the bar, or add a param like "exist_ok"?

mammothrider avatar Jul 26 '24 19:07 mammothrider

Also, the subprocess seems not working well with cmd array which has non-ascii input, so I just change my code to

        with open(ffmpeg_output_file, "a") as f:
            cmd = " ".join(self._ffmpeg_args)
            process = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=f)
            print(f"\nRunning: {cmd}\n")

And the ffmpeg probe has this problem as well...

mammothrider avatar Jul 26 '24 19:07 mammothrider

@mammothrider I don't understand what the issue is. <filename> already exists. Overwrite? [Y/N] is not hidden by the progress bar and it is shown before the progress bar.

Example terminal output if you enter y:

PS C:\Users\hshaf\Desktop\bfp-test> python main.py
The duration of 1.webm has been detected as 168.168 seconds.
output.mp3 already exists. Overwrite? [Y/N]: y

Running: ffmpeg -y -i 1.webm -c:a libmp3lame output.mp3 -hide_banner -loglevel verbose -progress pipe:1 -nostats

 93%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████▍                  | 156.8/168.2 [00:01<00:00, 149.32s/s]

Done! To see FFmpeg's output, check out ffmpeg_output\[1.webm].txt

Example terminal output if you enter n:

PS C:\Users\hshaf\Desktop\bfp-test> python main.py
The duration of 1.webm has been detected as 168.168 seconds.
output.mp3 already exists. Overwrite? [Y/N]: n
FFmpeg will not run as the output filename already exists, and you do not want it to be overwritten.

CrypticSignal avatar Oct 17 '24 21:10 CrypticSignal

was running on v2.1.5 and got this problem. just upgrade and try the v2.3.1, problem fixed.

mammothrider avatar Oct 29 '24 18:10 mammothrider