CaesarCipher icon indicating copy to clipboard operation
CaesarCipher copied to clipboard

Enhanced Algorithm for Encrypting and Decrypting a Caesar Cipher

Open VerisimilitudeX opened this issue 2 years ago • 7 comments

VerisimilitudeX avatar Aug 16 '22 07:08 VerisimilitudeX

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 16 '22 07:08 CLAassistant

@Sascha-T @arguiot @arwn could someone please review this PR? Thanks!

VerisimilitudeX avatar Dec 29 '22 00:12 VerisimilitudeX

Sorry for the delay, since the merge with Cryptool, we don't really maintain repos actively anymore! I think this PR looks good

arguiot avatar Dec 29 '22 06:12 arguiot

Is there a way to make it shorter? 800 lines for this cipher seems way too big compared to other languages

arguiot avatar Dec 29 '22 06:12 arguiot

Hey @arguiot, no worries! Sure thing, I can reduce the number of lines for this cipher. Is there a certain number you want me to target?

VerisimilitudeX avatar Dec 29 '22 06:12 VerisimilitudeX

It's not necessarily a number of line required but more of an optimization problem. If you can use more of the standard library to just make the cipher works in a minimal way, that would be great!

arguiot avatar Dec 29 '22 08:12 arguiot

Alright, sounds great! I'll ping you again once I resolve this (ETA 12/31). Sorry for the trouble btw.

VerisimilitudeX avatar Dec 31 '22 04:12 VerisimilitudeX

@lukalafaye awesome thank you!

VerisimilitudeX avatar Aug 06 '24 08:08 VerisimilitudeX