steam-deck-utilities icon indicating copy to clipboard operation
steam-deck-utilities copied to clipboard

feat: add GPU tab to display VRAM info

Open ajite opened this issue 1 year ago • 8 comments

Hi,

I thought it will be nice to have a tab to display the VRAM and teach people how to change it. (native speaker might help to review my english)

I am not proficient in go and tried to adapt to your style. I did not see any Unit Tests but I could add some. (e.g.: for the regex parsing).

1 2

ajite avatar Feb 22 '23 07:02 ajite

This is a great idea!

That said, the button feels misleading, like it will help you change it right in the UI. Maybe it should just be instructions directly in the tab instead, like a well-formatted text box?

I would also say that we should have the current setting "human readable" for everyone out there who doesn't know base-2 math 😉

CryoByte33 avatar Feb 22 '23 18:02 CryoByte33

the button feels misleading

I agree. I felt that using the information window made it look cleaner than something like below:

Screenshot_20230223_130057

We could also change the button text to: Show how to increase VRAM

What do you think ?

ajite avatar Feb 23 '23 05:02 ajite

We could also change the button text to: Show how to increase VRAM I think GPU is a little off, but I vote for VRAM to keep it short.

Also, would you mind changing the wording in the window to be like this? It should remove a few grammatical issues and clarify:


Minimum VRAM

How to change the minimum VRAM:

  1. Turn off the Steam Deck
  2. Press and hold the volume up button, press the power button, then release both
  3. Navigate to Setup Utility > Advanced > UMA Frame Buffer Size

4G is the recommended setting for most situations.

Please be aware that some games (RDR2) may experience degraded performance.

CryoByte33 avatar Feb 23 '23 05:02 CryoByte33

Great. It is much better like that.

Do you prefer option A or B.

Option A

3

Option B

1

2

ajite avatar Feb 23 '23 07:02 ajite

I prefer option A, it definitely seems cleaner.

Thank you for all the work you're putting into it!

CryoByte33 avatar Feb 23 '23 08:02 CryoByte33

Thank you for all the work you're putting into it!

Thanks to you my games run much better on my Steam Deck. I always wanted to learn how to develop in Go. That's a good opportunity.

I uploaded my change. I will try them on my Deck later today.

ajite avatar Feb 23 '23 08:02 ajite

It looks good other than the one comment, which I see you're addressing. Also having unit tests is a major win, I really need to add them 😅

Pending testing on Deck, this looks basically good to go!

CryoByte33 avatar Feb 23 '23 08:02 CryoByte33

It works on my Deck.

I tried with both 4GB and 256MB

ajite avatar Feb 23 '23 12:02 ajite

This might be a little bit of a nitpick, but I was finally able to test. Could you swap theme.MediaVideoIcon() with theme.ViewFullScreenIcon() for the tab icon? The camera is a bit off to me and I like the feel of the other better.

Also, please bump the version number to 2.0.2.

CryoByte33 avatar Mar 01 '23 11:03 CryoByte33

I've decided to just fix this post-merge since it's not "really" an issue.

CryoByte33 avatar Mar 02 '23 08:03 CryoByte33