RedditSharp-DEPRECATED-
RedditSharp-DEPRECATED- copied to clipboard
List of things that need to be done
- [ ] create a unit test
- [x] update the example project
- [x] more async methods and synchronous
- [x] ToDo for me: Unscrewing what i recently did
- [x] Nuget packaging figured out
- [x] DOCUMENTATION!!!!!!!!
Documentation would also be nice
I edited that in, thanks for reminding me, I started on that but it'll be difficult with how much there is to document
My first time contributing to an open source project so please forgive me if I break any etiquette.
I've run ReSharper to find issues in the solution and attached the results. I'd like to contribute getting these issues resolved & any other issues that can be later found.
all the enum stuff is fine, and since this is a DLL a lot of it's errors are going to be bad, also it asking for you to use "var" is not general coding style, it's complaining a lot about stuff that can't be changed, so most of those are non-issues, in fact, most of those issues are ignorable
Thanks.
I think, if acceptable, would be to create a pull for the namespaces. Specifically, the DateTimeExtensions.
The lead at my office is pretty particular on certain things. Variable declaration being one of those things he drives in to our skulls. This is our reference: https://msdn.microsoft.com/en-us/library/ff926074.aspx
Thanks again. :+1:
I generally perfer to avoid the var declaration to make clear what object is being passed around and why it's being passed around when it's declared, as not everyone uses visual studio or monodevelop, if you want to make a pull for the other stuff you can go ahead
Tried committing my branch but keep getting 403s. :(
Needs to be on your own fork, sorry, only a few have access to commit directly (I don't)
I got it! Pull request submitted.
Thanks for your patience and assistance.