RedditSharp-DEPRECATED- icon indicating copy to clipboard operation
RedditSharp-DEPRECATED- copied to clipboard

List of things that need to be done

Open chuggafan opened this issue 8 years ago • 9 comments

  • [ ] create a unit test
  • [x] update the example project
  • [x] more async methods and synchronous
  • [x] ToDo for me: Unscrewing what i recently did
  • [x] Nuget packaging figured out
  • [x] DOCUMENTATION!!!!!!!!

chuggafan avatar Jul 13 '16 15:07 chuggafan

Documentation would also be nice

cyian-1756 avatar Aug 22 '16 03:08 cyian-1756

I edited that in, thanks for reminding me, I started on that but it'll be difficult with how much there is to document

chuggafan avatar Aug 22 '16 14:08 chuggafan

My first time contributing to an open source project so please forgive me if I break any etiquette.

I've run ReSharper to find issues in the solution and attached the results. I'd like to contribute getting these issues resolved & any other issues that can be later found.

Code Issues in 'RedditSharp'.txt

ghost avatar Sep 01 '16 23:09 ghost

all the enum stuff is fine, and since this is a DLL a lot of it's errors are going to be bad, also it asking for you to use "var" is not general coding style, it's complaining a lot about stuff that can't be changed, so most of those are non-issues, in fact, most of those issues are ignorable

chuggafan avatar Sep 02 '16 00:09 chuggafan

Thanks.

I think, if acceptable, would be to create a pull for the namespaces. Specifically, the DateTimeExtensions.

The lead at my office is pretty particular on certain things. Variable declaration being one of those things he drives in to our skulls. This is our reference: https://msdn.microsoft.com/en-us/library/ff926074.aspx

Thanks again. :+1:

ghost avatar Sep 02 '16 00:09 ghost

I generally perfer to avoid the var declaration to make clear what object is being passed around and why it's being passed around when it's declared, as not everyone uses visual studio or monodevelop, if you want to make a pull for the other stuff you can go ahead

chuggafan avatar Sep 02 '16 00:09 chuggafan

Tried committing my branch but keep getting 403s. :(

ghost avatar Sep 02 '16 21:09 ghost

Needs to be on your own fork, sorry, only a few have access to commit directly (I don't)

chuggafan avatar Sep 02 '16 21:09 chuggafan

I got it! Pull request submitted.

Thanks for your patience and assistance.

ghost avatar Sep 02 '16 21:09 ghost