nightwatch-vrt icon indicating copy to clipboard operation
nightwatch-vrt copied to clipboard

Unnoticed colour change with threshold 0

Open steffanwilliams opened this issue 6 years ago • 2 comments

While comparing latest screenshots to baseline, I expected that the following colour difference would have triggered a test failure, however this still passes:

badge--destructive

badge--destructive-1

I have threshold: 0 specified in my config, but I just wanted to check if there still some tolerance being applied when comparing screenshots?

steffanwilliams avatar Nov 20 '18 10:11 steffanwilliams

Tried this today and it only works if the threshold optional parameter is not passed at all. Threshold set to anything causes the test to pass, even when I completely change padding and colour of the element.

SeanThompsonUptick avatar Mar 07 '19 05:03 SeanThompsonUptick

For me if threshold is 0 then tests will pick up differences but if anything over 0 (0.1, 0.01) tests will pass with even major text changes, so something is broken here.

altescape avatar Aug 05 '21 11:08 altescape