Crucible icon indicating copy to clipboard operation
Crucible copied to clipboard

Suggestion: Please Backport Paper Incremental world saving

Open StoneLegion opened this issue 3 years ago • 4 comments

Sadly I don't know where the code is, etc. I do know it was added in 1.14 and I do think they added fixes to it from 1.14 and on.

Either way if it's something worth checking out for the future we love to see it. Right now Fastcraft seems to have their own Internal fix for it that helps with level.dat save but of course incompatible with Crucible.

https://github.com/PaperMC/Paper

StoneLegion avatar May 28 '21 16:05 StoneLegion

Its this patch https://github.com/PaperMC/Paper/blob/master/Spigot-Server-Patches/0361-incremental-chunk-saving.patch

EverNife avatar May 28 '21 19:05 EverNife

Its this patch https://github.com/PaperMC/Paper/blob/master/Spigot-Server-Patches/0361-incremental-chunk-saving.patch

The patch is here now https://github.com/PaperMC/Paper/blob/master/patches/server/0450-incremental-chunk-and-player-saving.patch

quentin452 avatar Sep 16 '22 10:09 quentin452

Well, after more than a year, now i do understand what this patch does.

By default, when the server map is being saved, all chunks are saved at once.

This patch allows to split the saving process though ticks. But is not that simple, it has a few shenanigans happening as well.

Should theoretically reduce lag spikes on world saving, but there are things on this patch that does not exist on 1.7.10 and has a different logic going on, should be carefully implemented to prevent random bugs. And just like the patch, keep as optional.

Some servers take like a second or two to save the map (lag spike), this patch should reduce the lag and split this save process over a few seconds.

https://www.reddit.com/r/admincraft/comments/byq9r5/paper_114_incremental_world_saving/

EverNife avatar Sep 16 '22 10:09 EverNife

still hoping this happens someday. with how bloated GTNH is it would help a lot. It seems the bigger the level.dat bloat is the higher it works I assume dumping / compressing everything into it.

StoneLegion avatar Dec 10 '22 23:12 StoneLegion